Advance RFC #0637 "Facilitate customization of setupTest* functions" to Stage Recommended #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emberjs-rfcs-bot
added
RFC Advancement
S-Recommended
|
Before this can be moved to recommended, to-do tasks include:
|
kategengler
changed the title
|
The status here is: we need to decide whether we're really going to prioritize codemods and/or lints. It seems like a fine thing to do, but if nobody is motivated to do it we don't want to let this RFC linger in this stage forever. The codemod is a relatively easy, but the cost of not having it is also not very high. |
|
@mansona is going to help make a lint for this. Once we have the lint, I think we can move to Recommended. |
|
@mansona mentioned that he has generated questions about the lint strategy and plans to open a PR on the ember eslint plugin repo to discuss. |
|
Status update here is that nobody has worked on lints yet. If they don't happen, this can advance without them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advance #637 to the Recommended Stage
Summary
This pull request is advancing the RFC to the Recommended Stage.
An FCP is required before merging this PR to advance.
Recommended Stage Summary
The "Recommended" stage is the final milestone for an RFC. It provides a signal to the wider community to indicate that a feature has been put through its ecosystem paces and is ready to use.
To reach the "Recommended" stage, the following should be true:
If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.
If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.
If the proposal updates or replaces an existing feature, high-quality codemods are available.
If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.
If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".
Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met.
An FCP is required to enter this stage. Multiple RFCs may be moved as a batch into "Recommended" with the same PR.
Checklist to move to Recommended
If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".Final Comment Periodlabel has been added to start the FCPCriteria for moving to Recommended (required)
A set of criteria for moving this RFC to the Recommended Stage, following release:
Draft a blog post to explain the value/motivation/use cases/etc